MiSTer FPGA Forum

pgimeno wrote: ↑Fri Aug 19, 2022 3:36 pm
Wikipedia is not the best source for interrupt information. Ralf Brown's interrupt list has this to say about this function:

Code: Select all

--------B-1605-------------------------------
INT 16 - KEYBOARD - STORE KEYSTROKE IN KEYBOARD BUFFER (AT/PS w enh keybd only)
        AH = 05h
        CH = BIOS scan code
        CL = ASCII character
Return: AL = status
            00h if successful
            01h if keyboard buffer full
        AH destroyed by many BIOSes

Emphasis in "(AT/PS w enh keybd only)"

It also lists different behaviours for this function on PCjr and Tandy 2000.

You can emulate it by grabbing the circular buffer pointers in the BIOS memory area and inserting the key in the buffer yourself.

Procedure StuffKeyCode(KeyCode : word); assembler;
Asm
  cli
  mov es, Seg0040
  mov di, 001Ch
  mov ax, KeyCode
  mov bx, es:[di]
  mov es:[bx], ax
  add byte ptr es:[di], 2
  cmp byte ptr es:[di], 60
  jle @end
  mov byte ptr [es:di], 30
@end:
  sti
End;

MicroCoreLabs wrote: ↑Fri Aug 19, 2022 7:06 pm Of course the SS is necessarily modified when an interrupt is taken. The DS is not. Suspicious, no?

I believe the sequence you isolated is being interrupted in the middle of the REP, possibly after the first copy. And on the genuine 8088 which has a bug where only the prefix preceding the MOVSB is saved.

Also, I suspect that DEBUG will also debounce the REP and maybe the reason you only see one successful copy.

Maybe you can allow this sequence to run and use a breakpoint on an opcode after the sequence to see if all bytes were copied.

MicroCoreLabs wrote: ↑Sat Aug 20, 2022 4:40 am Could you add some MCL86 signals to SignalTap with a trigger on the 0x5C write?

The first MOVSB was successful and after this instruction CX equals zero, so it appears that the CX number of bytes were transferred with all but the first being read from or written to the wrong segment. Triggering on the first write and looking at the subsequent cycles will tell us the story.

We need to see the BIU signals: biu_muxed_segment, addr_out_temp, EU_BIU_COMMAND, biu_state, and the 8088 local bus would be helpful.

If you trigger on the 0x5C write we should be able to see the subsequent segment-overriden read and write cycles as requested by the EU.

That said, im not sure the prefixed MOVSB is broken. I don't think DEBUG will preserve all of an opcodes prefixes if it is a genuine 8088, so the example you showed using another emulator may not reflect what the real silicon is doing. The MCL86 does try to adopt these quirks...

The bug in DOSMAX may be somewhere else...

MicroCoreLabs wrote: ↑Sat Aug 20, 2022 6:55 am I think I found the error in the microcode. It looks like the segment override selection is being cleared by mistake across all string opcodes.

For a quick fix can you look for the sequence 4ddf0000 5c7f0000 in the microcode - there should be eight instances of this sequence.

For each one please change the 4ddf0000 to 4ddf0003 and see how it works!

suww37 wrote: ↑Sat Aug 20, 2022 2:30 pm In addition to ".img", Can you also allow ".ima" to recognize the floppy disk image extension? The two files have different extensions but are the same image.

This would be the definitive change for an official release or do you think it needs a different solution?

kubbie wrote: ↑Sat Aug 20, 2022 6:46 pm I cannot seem to be able to compile the pcxt.rom and tandy.rom. I keep getting error invalid character '-' (U+00B7). Thats the line for the

C:\PCXT>python make_rom_with_ibm5160.py
File "C:\PCXT\make_rom_with_ibm5160.py", line 68
<title>PCXT_MiSTer/make_rom_with_ibm5160.py at main · spark2k06/PCXT_MiSTer · GitHub</title>
^
SyntaxError: invalid character '·' (U+00B7)

Flandango wrote: ↑Sat Aug 20, 2022 7:19 pm

kubbie wrote: ↑Sat Aug 20, 2022 6:46 pm I cannot seem to be able to compile the pcxt.rom and tandy.rom. I keep getting error invalid character '-' (U+00B7). Thats the line for the

C:\PCXT>python make_rom_with_ibm5160.py
File "C:\PCXT\make_rom_with_ibm5160.py", line 68
<title>PCXT_MiSTer/make_rom_with_ibm5160.py at main · spark2k06/PCXT_MiSTer · GitHub</title>
^
SyntaxError: invalid character '·' (U+00B7)

Looks like you downloaded the script from git without clicking on the RAW button first. Click on the Raw button then save it.

Flandango wrote: ↑Sat Aug 20, 2022 7:19 pm

kubbie wrote: ↑Sat Aug 20, 2022 6:46 pm I cannot seem to be able to compile the pcxt.rom and tandy.rom. I keep getting error invalid character '-' (U+00B7). Thats the line for the

C:\PCXT>python make_rom_with_ibm5160.py
File "C:\PCXT\make_rom_with_ibm5160.py", line 68
<title>PCXT_MiSTer/make_rom_with_ibm5160.py at main · spark2k06/PCXT_MiSTer · GitHub</title>
^
SyntaxError: invalid character '·' (U+00B7)

Looks like you downloaded the script from git without clicking on the RAW button first. Click on the Raw button then save it.

suww37 wrote: ↑Sat Aug 20, 2022 3:20 pm

suww37 wrote: ↑Sat Aug 20, 2022 2:30 pm In addition to ".img", Can you also allow ".ima" to recognize the floppy disk image extension? The two files have different extensions but are the same image.

please ".dsk" extesion also.

spark2k06 wrote: ↑Mon Aug 15, 2022 9:38 am

wark91 wrote: ↑Mon Aug 15, 2022 9:07 am Thank you for the update.
I think it will be great to keep option on the OSD to load BIOS or XTIDE.

The fact is that now the core reset is linked to the selected model, which automatically loads the appropriate ROM. To keep the option to load ROM and XTIDE, I should adapt it to ignore the PC model during the reset... via some developer option, because that's really what it is.

I will keep this in mind for future revisions.

spark2k06 wrote: ↑Sun Aug 21, 2022 5:22 am

suww37 wrote: ↑Sat Aug 20, 2022 3:20 pm

suww37 wrote: ↑Sat Aug 20, 2022 2:30 pm In addition to ".img", Can you also allow ".ima" to recognize the floppy disk image extension? The two files have different extensions but are the same image.

please ".dsk" extesion also.

IMA added, I am not so sure that DSK images are in raw format.

Caldor wrote: ↑Sat Aug 20, 2022 11:20 pm I made some Windows batch scripts for creating the ROM files:
http://dionysus.dk/devstuff/mister/

The jukost one requires WSL installed I think, the Linux subsystem. It will also create the file as pcxt_jukost.rom so it has to be renamed like the open source ones do.

The scripts should download the files from the websites, also the ide_xtl.rom from the git, extract zip files and combine the different files.

Hmm, just got an idea. I will add the zero file that is the problem for the jukost script. Then it should work I think even without WSL. All that part does is help create an empty file of a certain size. So copy the file: "zerofile.tmp" as well.

Daniel8b wrote: ↑Sun Aug 21, 2022 11:25 am I noticed an issue with the keyboard not reacting properly to shift/capslock keys. Should I report it here or at Github?

Goingdown wrote: ↑Sun Aug 21, 2022 5:46 pm

Daniel8b wrote: ↑Sun Aug 21, 2022 11:25 am I noticed an issue with the keyboard not reacting properly to shift/capslock keys. Should I report it here or at Github?

Are you using keyb to load non-us keyboard layout? That does not work properly yet.