MiSTer FPGA Forum

jopdorp wrote: ↑Sat Apr 30, 2022 3:42 pm

mario64 wrote: ↑Sat Apr 30, 2022 2:47 pm

jopdorp wrote: ↑Sat Apr 30, 2022 8:12 am The walk sound is integrated into the DK core.

The release pullrequest is pending, but you can already download the build here:
https://github.com/jopdorp/Arcade-Donke ... 220429.rbf

It is great to see so much enthusiasm around the analog sounds of these arcades!
Persuaded by the enthusiasm here and on the Discord, I've created a Patreon, to help me be able to spend more time on these projects.

https://www.patreon.com/jopdorp

If you like the work, and want me to support me to keep on building these analog sound implementations, become a patron

This release doesn't work at all for me. I'm using the 4/29 rbf along with the included mra. Upon launch the game just sits there glitching and playing the mario death sound over and over.

Thank you for reporting this, do you have any more information for me to reproduce?
What addons are you using, power adapter, does it also happen when you don't have any expansion boards and peripherals attached?

pgimeno wrote: ↑Sat Apr 30, 2022 4:17 pm Works quite well for me.

There's a very minor bug, that you could argue is more of a style thing than a bug. In this change:

Code: Select all

-	.I_SW(I_DKJR ? 3'b000 : W_6H_Q[2:0])
+	.I_SW(I_DKJR ? 3'b000 : W_6H_Q[2:1])

the 3'b000 should have become a 2'b00. It won't make a difference; I'm not sure if Quartus will be issuing a warning for it but if it does, it's an easily avoidable warning

I'd also check how is W_6H_Q[0] generated, to see if it needs cleanup.

It's a bit confusing that the patch is already committed to master, but the PR is still open. What happened there?

lagomorph wrote: ↑Sat Apr 30, 2022 4:52 pm I commented on the original PR that got merged. I'm in the camp that was slightly bothered by the samples in that they can't reproduce the random nature of how the walking sound is actually produced. I'd think though that anyone sensitive enough to want an improvement in the existing walking sound would not be convinced that this is an improvement. It sounds too high pitched and squeaky compared to the original. The existing samples are closer to correct. I'm not sure why it sounds so off based on the modeling approach taken which is closer to what actually happens and I haven't seen much negative feedback. I hope everyone concerned can try it out for themselves and sanity check my assessment before this gets released.

lagomorph wrote: ↑Sat Apr 30, 2022 4:52 pm I commented on the original PR that got merged. I'm in the camp that was slightly bothered by the samples in that they can't reproduce the random nature of how the walking sound is actually produced. I'd think though that anyone sensitive enough to want an improvement in the existing walking sound would not be convinced that this is an improvement. It sounds too high pitched and squeaky compared to the original. The existing samples are closer to correct. I'm not sure why it sounds so off based on the modeling approach taken which is closer to what actually happens and I haven't seen much negative feedback. I hope everyone concerned can try it out for themselves and sanity check my assessment before this gets released.

mhartman wrote: ↑Sat Apr 30, 2022 9:13 pm BTW, can someone more skilled than I (that’s anyone who can actually work with this code) check on the digital music code in Mister. For some reason, the rhythm/notes of the post board song is off.

Getting the analog sounds right would be a miracle, but it won’t be that great overall if the digital music is still off.

thorr wrote: ↑Sun May 01, 2022 1:15 am Just tried the current version. It's great to see the progress. I am looking forward to the new improved version. I was wondering if there are any samples still being used and if so, will those will be modeled as well? Thanks!

jopdorp wrote: ↑Sun May 01, 2022 6:29 am

thorr wrote: ↑Sun May 01, 2022 1:15 am Just tried the current version. It's great to see the progress. I am looking forward to the new improved version. I was wondering if there are any samples still being used and if so, will those will be modeled as well? Thanks!

Yes, the rest of the analog sounds are still samples, for example the jump sound.
I'm planning to continue on other cores first, and then come back to Donkey Kong later to do more sounds.

Robgus wrote: ↑Sun May 01, 2022 7:06 am Amazing! Thank you for doing this! How do I try the current version, do I just run the Update script?

mhartman wrote: ↑Sat Apr 30, 2022 9:10 pm

lagomorph wrote: ↑Sat Apr 30, 2022 4:52 pm I commented on the original PR that got merged. I'm in the camp that was slightly bothered by the samples in that they can't reproduce the random nature of how the walking sound is actually produced. I'd think though that anyone sensitive enough to want an improvement in the existing walking sound would not be convinced that this is an improvement. It sounds too high pitched and squeaky compared to the original. The existing samples are closer to correct. I'm not sure why it sounds so off based on the modeling approach taken which is closer to what actually happens and I haven't seen much negative feedback. I hope everyone concerned can try it out for themselves and sanity check my assessment before this gets released.

I’m traveling, but I’ll check on this when I get home. I have 4 original DK boards and an original machine to go by. BTW, the analog sound on each PCB that I have is slightly, but noticeably, different. I’m guessing due to tolerance differences in the parts.

thorr wrote: ↑Sun May 01, 2022 10:18 am

Robgus wrote: ↑Sun May 01, 2022 7:06 am Amazing! Thank you for doing this! How do I try the current version, do I just run the Update script?

Download it from here: https://github.com/jopdorp/Arcade-Donke ... 220429.rbf and rename it without the Arcade- in the front and put it in the same folder as the other Donkey Kong rbf.

thorr wrote: ↑Sun May 01, 2022 4:49 pm Thanks! Here is a direct link to the rbf file in case anyone can't find it: https://github.com/MiSTer-devel/Arcade- ... 220501.rbf

I tried it and it sounds much better. Excellent work! I picked a random Arcade low pass filter. Which filter do you recommend?

thorr wrote: ↑Sun May 01, 2022 10:43 pm You may have some old files laying around. I had to delete some files previously.

thorr wrote: ↑Sun May 01, 2022 4:49 pm Thanks! Here is a direct link to the rbf file in case anyone can't find it: https://github.com/MiSTer-devel/Arcade- ... 220501.rbf

I tried it and it sounds much better. Excellent work! I picked a random Arcade low pass filter. Which filter do you recommend?

mario64 wrote: ↑Sun May 01, 2022 8:00 pm Core still doesn't work for me using the newest update. Same symptoms as before. Upon launch the game just sits there glitching and playing the mario death sound over and over. No one else is seeing this?

jopdorp wrote: ↑Mon May 02, 2022 6:08 am

mario64 wrote: ↑Sun May 01, 2022 8:00 pm Core still doesn't work for me using the newest update. Same symptoms as before. Upon launch the game just sits there glitching and playing the mario death sound over and over. No one else is seeing this?

I'm sorry to hear you're still having problems.
There are some timing warnings in this build that I'm still going to look at, hope that will resolve it.

Just to double check, the builds before mine do work?

mario64 wrote: ↑Mon May 02, 2022 2:20 pm Could someone please post a known working MRA for this core? Thank you.