NeoGeo Art of Fighting, MAME style rom entry problem

mt32pi · Unread post by **mt32pi** » Mon Sep 06, 2021 3:14 pm

Hello.
I have a question.

This code is mame style code for Art of Fighting.

https://github.com/MiSTer-devel/NeoGeo_ ... ter/xml.md
-----------------------------------------------------------------------------------------
Example MAME style rom entry
Below is an example of an XML entry for a MAME style ROM set.

<romset name="aof" pcm="1" altname="Art of Fighting">
<file name="044-p1.p1" type="P" index="4" offset="0"/>
<file name="044-s1.s1" type="S" index="8" offset="0"/>
<file name="044-c1.c1" type="C" index="64" offset="0"/>
<file name="044-c2.c2" type="C" index="65" offset="0"/>
<file name="044-c1.c1" type="C" index="72" offset="0x100000"/>
<file name="044-c2.c2" type="C" index="73" offset="0x100000"/>
<file name="044-c3.c3" type="C" index="68" offset="0"/>
<file name="044-c4.c4" type="C" index="69" offset="0"/>
<file name="044-c3.c3" type="C" index="76" offset="0x100000"/>
<file name="044-c4.c4" type="C" index="77" offset="0x100000"/>
<file name="044-m1.m1" type="M" index="9" offset="0"/>
<file name="044-v2.v2" type="V" index="16" offset="0"/>
<file name="044-v4.v4" type="V" index="20" offset="0"/>
</romset>
-----------------------------------------------------------------------------------------
When applied to romsets.xml, the graphic is broken.

MAME XML information :
------------------------------------------------------------------------------------
ROM_REGION( 0x800000, "cslot1:sprites", 0 )
ROM_LOAD16_BYTE( "044-c1.c1", 0x000000, 0x100000, ~~~~~~)
ROM_CONTINUE( 0x400000, 0x100000 )

ROM_LOAD16_BYTE( "044-c2.c2", 0x000001, 0x100000, ~~~~~~)
ROM_CONTINUE( 0x400001, 0x100000 )

ROM_LOAD16_BYTE( "044-c3.c3", 0x200000, 0x100000, ~~~~~~)
ROM_CONTINUE( 0x600000, 0x100000 )

ROM_LOAD16_BYTE( "044-c4.c4", 0x200001, 0x100000, ~~~~~~)
ROM_CONTINUE( 0x600001, 0x100000 )
------------------------------------------------------------------------------------
The c3 and c4 rom load addresses are 0x200000, 0x200001

So, I modified it as below. c3(index=68), c4(index=69)
--------------------------------------------------------------------------------------
<romset name="aof" pcm="1" altname="Art of Fighting">
<file name="044-p1.p1" type="P" index="4" offset="0"/>
<file name="044-s1.s1" type="S" index="8" offset="0"/>
<file name="044-c1.c1" type="C" index="64" offset="0"/>
<file name="044-c2.c2" type="C" index="65" offset="0"/>
<file name="044-c1.c1" type="C" index="72" offset="0x100000"/>
<file name="044-c2.c2" type="C" index="73" offset="0x100000"/>
<file name="044-c3.c3" type="C" index="68" offset="0x200000"/>
<file name="044-c4.c4" type="C" index="69" offset="0x200000"/>
<file name="044-c3.c3" type="C" index="76" offset="0x100000"/>
<file name="044-c4.c4" type="C" index="77" offset="0x100000"/>
<file name="044-m1.m1" type="M" index="9" offset="0"/>
<file name="044-v2.v2" type="V" index="16" offset="0"/>
<file name="044-v4.v4" type="V" index="20" offset="0"/>
</romset>
--------------------------------------------------------------------------------------
Only player character graphics are broken.

Is there any solution?

paulbnl · Unread post by **paulbnl** » Mon Sep 06, 2021 6:30 pm

The offset in MiSTer xml is the offset into the file (ex. 044-c1.c1) The load address is set by the index. 0x000000 in Mame is index 64, 0x0000001 is index 65, 0x200000 is index 68, 0x200001 is index 69, etc.

This is the correct xml:

Code: Select all

    <romset name="aof" pcm="1" altname="Art of Fighting" altnamej="Ryuuko no Ken" publisher="SNK" year="1992">
        <file name="044-p1.p1" index="4"/>
        <file name="044-s1.s1" index="8"/>
        <file name="044-c1.c1" index="64" offset="0x000000" length="0x100000"/>
        <file name="044-c2.c2" index="65" offset="0x000000" length="0x100000"/>
        <file name="044-c3.c3" index="68" offset="0x000000" length="0x100000"/>
        <file name="044-c4.c4" index="69" offset="0x000000" length="0x100000"/>
        <file name="044-c1.c1" index="72" offset="0x100000" length="0x100000"/>
        <file name="044-c2.c2" index="73" offset="0x100000" length="0x100000"/>
        <file name="044-c3.c3" index="76" offset="0x100000" length="0x100000"/>
        <file name="044-c4.c4" index="77" offset="0x100000" length="0x100000"/>
        <file name="044-m1.m1" index="9"/>
        <file name="044-v2.v2" index="16"/>
        <file name="044-v4.v4" index="20"/>
    </romset>

Here is the xml for some other Mame roms:

mame-romsets.xml.zip: (13.46 KiB) Downloaded 220 times

mt32pi · Unread post by **mt32pi** » Tue Sep 07, 2021 12:14 am

paulbnl wrote: ↑Mon Sep 06, 2021 6:30 pm The offset in MiSTer xml is the offset into the file (ex. 044-c1.c1) The load address is set by the index. 0x000000 in Mame is index 64, 0x0000001 is index 65, 0x200000 is index 68, 0x200001 is index 69, etc.

This is the correct xml:

Code: Select all

    <romset name="aof" pcm="1" altname="Art of Fighting" altnamej="Ryuuko no Ken" publisher="SNK" year="1992">
        <file name="044-p1.p1" index="4"/>
        <file name="044-s1.s1" index="8"/>
        <file name="044-c1.c1" index="64" offset="0x000000" length="0x100000"/>
        <file name="044-c2.c2" index="65" offset="0x000000" length="0x100000"/>
        <file name="044-c3.c3" index="68" offset="0x000000" length="0x100000"/>
        <file name="044-c4.c4" index="69" offset="0x000000" length="0x100000"/>
        <file name="044-c1.c1" index="72" offset="0x100000" length="0x100000"/>
        <file name="044-c2.c2" index="73" offset="0x100000" length="0x100000"/>
        <file name="044-c3.c3" index="76" offset="0x100000" length="0x100000"/>
        <file name="044-c4.c4" index="77" offset="0x100000" length="0x100000"/>
        <file name="044-m1.m1" index="9"/>
        <file name="044-v2.v2" index="16"/>
        <file name="044-v4.v4" index="20"/>
    </romset>

Here is the xml for some other Mame roms:
mame-romsets.xml.zip

Thank you so much !!! Perfect !!! Great !

This game needs to be exactly the range of memory addresses with the length command.
Thank you for the attached file.

mt32pi · Unread post by **mt32pi** » Tue Sep 07, 2021 2:38 pm

+
King of Fighters 99 (non encrypted P,decrypted C)

This code is a problem that energy bars and letters are not displayed.
I can't solve it.

Code: Select all

		<romset name="kof99nd" pcm="1" altname="King of Fighters 99 (non encrypted P,decrypted C)" publisher="SNK" year="1994" ram="2">
		<file name="251-p1d.p1" index="4"/>
		<file name="251-p2d.p2" index="6"/>
		<file name="251-c1d.c1" index="64"/>
		<file name="251-c2d.c2" index="65"/>
		<file name="251-c3d.c3" index="96"/>
		<file name="251-c4d.c4" index="97"/>
		<file name="251-c5d.c5" index="128"/>
		<file name="251-c6d.c6" index="129"/>
		<file name="251-c7d.c7" index="160"/>
		<file name="251-c8d.c8" index="161"/>
		<file name="251-m1.m1" index="9"/>
		<file name="251-v1.v1" index="16"/>
		<file name="251-v2.v2" index="24"/>
		<file name="251-v3.v3" index="32"/>
		<file name="251-v4.v4" index="40"/> 
	</romset>

paulbnl · Unread post by **paulbnl** » Tue Sep 07, 2021 3:38 pm

I think you just need the s1 file. <file name="251-s1.s1" index="8"/> I found it as kf99n_s1.rom in kof99nd.zip. I couldn't find non encrypted P but 152-p1.p1 & 152-p2.sp2 from kof99ka also work.

mt32pi · Unread post by **mt32pi** » Tue Sep 07, 2021 3:53 pm

You are genius!
Perfect! Thank you so so much.

mt32pi · Unread post by **mt32pi** » Sat Sep 11, 2021 5:07 am

Another way.
Use the non-encrypted ROM, neoragex ROM

MiSTer FPGA Forum

NeoGeo Art of Fighting, MAME style rom entry problem

NeoGeo Art of Fighting, MAME style rom entry problem

Re: NeoGeo Art of Fighting, MAME style rom entry problem

Re: NeoGeo Art of Fighting, MAME style rom entry problem

Re: NeoGeo Art of Fighting, MAME style rom entry problem

Re: NeoGeo Art of Fighting, MAME style rom entry problem

Re: NeoGeo Art of Fighting, MAME style rom entry problem

Re: NeoGeo Art of Fighting, MAME style rom entry problem